Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty query param name breaks proxy to external URL #68081

Closed
wants to merge 3 commits into from
Closed

Fix empty query param name breaks proxy to external URL #68081

wants to merge 3 commits into from

Conversation

flippidippi
Copy link

@flippidippi flippidippi commented Jul 23, 2024 •
edited
Loading

fixes #68039

Fix issue with shared/lib/router/utils/prepare-destination.js creating invalid URLs when there is an empty query param name and rewriting/redirecting to an external URL.

@flippidippi flippidippi mentioned this pull request Jul 31, 2024
Merged
@flippidippi
Copy link
Author

flippidippi commented Sep 11, 2024 •
edited
Loading

Fixed with #68157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty query param name breaks proxy to external URL
2 participants
@flippidippi @ijjk